lkml.org 
[lkml]   [2010]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] rbd: replace the rbd sysfs interface
    On Wed, Nov 17, 2010 at 03:00:17PM -0800, Yehuda Sadeh Weinraub wrote:
    > On Wed, Nov 17, 2010 at 9:19 AM, Greg KH <greg@kroah.com> wrote:
    > > On Tue, Nov 16, 2010 at 04:32:09PM -0800, Yehuda Sadeh wrote:
    > >> Hi Greg,
    > >>
    > >> Following is the new rbd sysfs interface. It lists devices in their own
    > >> subdirectories, as well as their underlying snapshots. Please let us
    > >> know if there's any issue you think we missed or did wrong.
    > >>
    > >> Thanks,
    > >> Yehuda
    > >>
    > >> ---
    > >>
    > >> The new interface creates directories per mapped image
    > >> and under each it creates a subdir per available snapshot.
    > >> This allows keeping a cleaner interface within the sysfs
    > >> guidelines. The ABI documentation was updated too.
    > >>
    > >> Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
    > >> ---
    > >> ?Documentation/ABI/testing/sysfs-class-rbd | ? 83 +++
    > >> ?drivers/block/rbd.c ? ? ? ? ? ? ? ? ? ? ? | ?775 +++++++++++++++++------------
    > >> ?2 files changed, 547 insertions(+), 311 deletions(-)
    > >>
    > >> diff --git a/Documentation/ABI/testing/sysfs-class-rbd b/Documentation/ABI/testing/sysfs-class-rbd
    > >> new file mode 100644
    > >> index 0000000..4d96618
    > >> --- /dev/null
    > >> +++ b/Documentation/ABI/testing/sysfs-class-rbd
    > >> @@ -0,0 +1,83 @@
    > >> +What: ? ? ? ? ? ? ? ?/sys/class/rbd/
    > >
    > > I thought I mentioned that you should not add new classes to the kernel.
    > > Please don't do that, make it a bus_type instead.
    >
    >
    > Ahmm.. apparently not in the rbd related threads. So moving things
    > around and having rbd under /sys/bus we'll have the following:
    >
    > /sys/bus/rbd/drivers/rbd/..
    > add - add a device
    > remove - remove a device

    These files could go in /sys/bus/rbd/ directly instead of burying under
    2 more layers, right?

    >
    > /sys/bus/rbd/devices/<id>
    > name
    > pool
    > ...
    >
    > /sys/bus/rbd/devices/<id>/snaps/<name>
    > id
    > size
    > ...
    >
    >
    > Would this work?

    With the change mentioned above, I think that seems sane, do you?

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2010-11-18 02:35    [W:0.024 / U:66.960 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site