Messages in this thread | | | Subject | Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt | From | Daniel Walker <> | Date | Wed, 17 Nov 2010 16:35:08 -0800 |
| |
On Wed, 2010-11-17 at 16:29 -0800, Joe Perches wrote: > On Wed, 2010-11-17 at 15:30 -0800, Daniel Walker wrote: > > This adds a pr_fmt line which uses the __func__ macro. I also > > convert the current pr_ lines to remove their __func__ usage. > [] > > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > > @@ -765,8 +767,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, > > > > /* else require explicit machine-level constraints */ > > if (cmin <= 0 || cmax <= 0 || cmax < cmin) { > > - pr_err("%s: %s '%s' voltage constraints\n", > > - __func__, "invalid", name); > > + pr_err("%s '%s' voltage constraints\n", "invalid", > > + name); > > Using a separate pointer for invalid and unsupportable > doesn't save much text space and is very hard to grep. > > I think it's more intelligible as: > > pr_err("%s: Invalid voltage constraints\n", name);
I noticed that also, but I didn't feel like changing it when I did this.
there is another one here,
printk(KERN_WARNING "%s: could not add regulator_dev" " load sysfs\n", __func__);
I'm not sure what this one was suppose to say.
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
| |