lkml.org 
[lkml]   [2010]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add netdev led trigger
Hi!

> > > Add a netdev LED trigger for all Blinkenlights lovers...
> > > Originally taken from https://dev.openwrt.org/ticket/2776
> > > Slightly updated for 2.6.24 by Mickey Lauer <mickey@openmoko.org>
> > > and for 2.6.36 by Eric Cooper <ecc@cmu.edu>
> >
> > Nice!
> >
> > > +/*
> > > + * Configurable sysfs attributes:
> > > + *
> > > + * device_name - network device name to monitor
> > > + *
> > > + * interval - duration of LED blink, in milliseconds
> >
> > This needs to go to Doc/ somewhere.
>
> Documentation/ABI is the correct place for it.

I was hoping you'd comment on the ABI itself, too. It uses

echo "foo bar baz" > file
to enable/disable specific events to be "displayed". More traditional
interface would be

echo disable > file_foo
...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2010-11-17 20:59    [from the cache]
©2003-2011 Jasper Spaans