lkml.org 
[lkml]   [2010]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 17 Nov 2010 17:24:25 +0000
FromRussell King - ARM Linux <>
SubjectRe: [PATCH v2 05/20] ARM: LPAE: Introduce L_PTE_NOEXEC and L_PTE_NOWRITE
On Wed, Nov 17, 2010 at 05:22:12PM +0000, Catalin Marinas wrote:
> Ah, good point, that was the mask.
> So for dmacoherent we make sure that L_PTE_EXEC is cleared. I suspect
> we should now make sure that L_PTE_NOEXEC is set. For the other two,
> just leave them as they are.

Already done:

#define pgprot_dmacoherent(prot) \
- __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_BUFFERABLE)
+ __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_BUFFERABLE|L_PTE_XN)
...
#define pgprot_dmacoherent(prot) \
- __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_UNCACHED)
+ __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_UNCACHED|L_PTE_XN)

\
 
 \ /
  Last update: 2010-11-17 18:27    [from the cache]
©2003-2010