lkml.org 
[lkml]   [2010]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND PATCH] tags: put function prototypes back!
    Hello Marek,

    On Thu, Nov 04, 2010 at 10:24:16AM +0100, Uwe Kleine-König wrote:
    > Commit 7db86dc (ctags: usability fix) removed function prototypes from
    > tags file claiming "It makes no real sense to include function
    > prototypes".
    > But it is useful for quickly determining which header file developer
    > needs to include to fix compilation.
    >
    > Now if someone wants to remove forward declatations (which I agree are
    > baggage), write a postprocessing script.
    While sorting my pending patches I noticed that there's a typo, can you
    please do s/declatations/declarations/ when taking the patch.
    (Or tell me to resend an updated patch.) (I'd say the sentence before
    needs an "a" before developer, I'm not a native speaker though, so I
    kept Alexey's wording.)

    Best regards and thanks
    Uwe

    > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > ---
    > scripts/tags.sh | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/scripts/tags.sh b/scripts/tags.sh
    > index 8509bb5..e091db3 100755
    > --- a/scripts/tags.sh
    > +++ b/scripts/tags.sh
    > @@ -123,7 +123,7 @@ exuberant()
    > -I ____cacheline_internodealigned_in_smp \
    > -I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL \
    > -I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
    > - --extra=+f --c-kinds=-px \
    > + --extra=+f --c-kinds=+px \
    > --regex-asm='/^ENTRY\(([^)]*)\).*/\1/' \
    > --regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
    >
    > --
    > 1.7.2.3
    >
    >

    --
    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-11-17 10:09    [W:0.027 / U:1.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site