Messages in this thread | | | Date | Tue, 16 Nov 2010 10:02:44 +0000 | Subject | Re: [PATCH v2 02/20] ARM: LPAE: Factor out 2-level page table definitions into separate files | From | Catalin Marinas <> |
| |
On 16 November 2010 09:59, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Tue, Nov 16, 2010 at 09:14:52AM +0000, Catalin Marinas wrote: >> On 15 November 2010 23:31, Russell King - ARM Linux >> <linux@arm.linux.org.uk> wrote: >> > This should become: >> > >> > typedef struct { pteval_t pte; } pte_t; >> > >> > L_PTE_* can then be declared using linux/const.h stuff to typedef them >> > to pteval_t. >> >> I already do this for LPAE but can be done for the 2-level definitions >> for consistency. > > No you don't. You define the 2nd level definitions using pmd_t which > is _wrong_. pmd_t is the type of the pmd container, not the pmd value.
I was only referring to L_PTE_*. The PMD_* definitions are wrong indeed.
-- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |