lkml.org 
[lkml]   [2010]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 1/5] [PATCH 1/5] events: Add EVENT_FS the event filesystem
    On Tue, Nov 16, 2010 at 07:53:58PM -0500, Steven Rostedt wrote:
    > From: Steven Rostedt <srostedt@redhat.com>
    >
    > Copied mostly from debugfs, the eventfs is the filesystem
    > that will include stable tracepoints. Currently nothing
    > enables this filesystem as of this patch.

    What? Wait, I wrote tracefs a long time ago just for this, why not take
    that code and use it instead?

    {sigh} And I just deleted that old tracefs git tree today as I thought
    that idea was long gone and dead....

    >
    > Cc: Greg KH <gregkh@suse.de>
    > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    > ---
    > fs/Kconfig | 6 +
    > fs/Makefile | 1 +
    > fs/eventfs/Makefile | 4 +
    > fs/eventfs/file.c | 53 ++++++
    > fs/eventfs/inode.c | 433 +++++++++++++++++++++++++++++++++++++++++++++++

    This seems a bit big, I don't think you need all of this for some
    reason. Are you sure you can't make it smaller?

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2010-11-17 04:35    [W:3.977 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site