Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 16 Nov 2010 18:56:08 -0800 | Subject | Re: [PATCH] cciss: fix build for PROC_FS disabled |
| |
On Tue, Nov 16, 2010 at 5:00 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: > > Fix cciss driver for CONFIG_PROC_FS not enabled: > > drivers/block/cciss.c:4929: error: 'proc_cciss' undeclared (first use in this function)
Hmm. I would almost prefer to not have this #ifdef inside code, and solve it by simply moving the definition of "proc_cciss" to outside the other #ifdef CONFIG_PROC_FS.
That way it allways stays NULL, and without CONFIG_PROC_FS the code in question will all be empty inline function calls anyway, so the compiler will compile it all away (at the cost of just keeping that one unnecessary variable around).
I'd rather waste one useless pointer than have ugly source code.
Comments?
Linus
| |