Messages in this thread | | | Subject | Re: [RFC/RFT PATCH v3] sched: automated per tty task groups | From | Mike Galbraith <> | Date | Tue, 16 Nov 2010 19:14:20 -0700 |
| |
On Tue, 2010-11-16 at 20:31 -0500, Kyle McMartin wrote: > Hi Mike, > > On Mon, Nov 15, 2010 at 02:25:50PM -0700, Mike Galbraith wrote: > > --- linux-2.6.orig/drivers/tty/tty_io.c > > +++ linux-2.6/drivers/tty/tty_io.c > > @@ -3160,6 +3160,7 @@ static void __proc_set_tty(struct task_s > > put_pid(tsk->signal->tty_old_pgrp); > > tsk->signal->tty = tty_kref_get(tty); > > tsk->signal->tty_old_pgrp = NULL; > > + sched_autogroup_create_attach(tsk); > > } > > > > This is a bit of a problem, as it's called in_atomic context and kmalloc's > under GFP_KERNEL (which can sleep.) This results in sleep-under-spinlock > prints when CONFIG_DEBUG_SPINLOCK_SLEEP=y.
Yeah, I got another report about that today.
-Mike
| |