lkml.org 
[lkml]   [2010]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v5] Bluetooth: btwilink driver
    From
    >> +     /* Registration with ST layer is successful,
    >> +      * hardware is ready to accept commands from HCI core.
    >> +      */
    >> +     if (test_and_set_bit(HCI_RUNNING, &hdev->flags)) {
    >> +             clear_bit(HCI_RUNNING, &hdev->flags);
    >> +             err = st_unregister(ST_BT);
    >> +             if (err)
    >> +                     BT_ERR("st_unregister() failed with error %d", err);
    >> +             hst->st_write = NULL;
    >> +     }
    >
    >
    > What are you trying to do here? test_and_set_bit() result doesn't say
    > nothing about error and you shall put test_and_set_bit should be in the
    > beginning, to know if your device is already opened or not and then
    > clear_bit if some error ocurrs during the function.
    >

    Yeap, this piece of code beats me is well. Why is it an error if this
    bit wasn't already set?

    ~Vitaly
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-11-17 00:23    [W:0.022 / U:3.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site