Messages in this thread |  | | | Date | Tue, 16 Nov 2010 12:46:09 -0800 | | From | Randy Dunlap <> | | Subject | Re: rfc: rewrite commit subject line for subsystem maintainer preference tool |
| |
On Tue, 16 Nov 2010 12:42:36 -0800 Joe Perches wrote:
> On Tue, 2010-11-16 at 12:21 -0800, Randy Dunlap wrote: > > On Tue, 16 Nov 2010 19:55:31 +0000 Mark Brown wrote: > > I don't know what you asked Joe to change, but asking someone to use > > the documented canonical patch format: > > <quote> > > The canonical patch subject line is: > > Subject: [PATCH 001/123] subsystem: summary phrase > > </quote> > > should be fine. And there is no need for printf-ish templates > > for this in MAINTAINERS either. > > I've never read that before. Learn something new etc... > It seems path prefixes aren't good nor even commonly used. > > A review of kernel patch subjects: > > $ git log --no-merges --pretty=oneline | \ > cut -f2- -d" " | cut -f1 -d: | sort | uniq -c | sort -rn > > is interesting. Here's the head: > 5007 x86 > 3943 Staging > 3220 USB > 2790 sh > 2707 KVM > 2624 ARM > 2449 ALSA > 1571 Input > 1549 ASoC > 1470 iwlwifi > 1423 ACPI > 1397 mac80211 > 1384 V4L/DVB > 1226 sched > 1200 Btrfs > 1184 powerpc > 1106 [NETFILTER] > 1080 MIPS > 1049 net > 1047 ide > 1014 drm/i915 > 993 staging > 921 ath9k
$ARCH is a commonly accepted substitute for subsystem.
And yes, lots of people use <drivername> there as well.
> Some subsystem maintainers like upper case, some mixed, some lower. > Some aren't consistent. (Staging/staging)
Case usually doesn't matter to most of us.
> It doesn't seem a rule can be pregenerated so maybe adding these > "C:" lines to MAINTAINERS has some value.
Hopefully it won't go that far.
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
|  |