lkml.org 
[lkml]   [2010]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: rfc: rewrite commit subject line for subsystem maintainer preference tool
On Tue, 16 Nov 2010 18:12:27 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Nov 16, 2010 at 06:37:07PM +0100, Florian Mickler wrote:
>
> > My first reaction to this is, it's silly. Certainly a
> > subsystem-maintainer is capable of hacking something together that
> > suits his needs or may just use a good editor to get the job done.
> > After all, he might want to edit the commit message anyway. Also he has
> > to have his act together for all non-conforming submitters anyway,
> > because shurely, telling people to re-edit their patches subject line
> > is not what one would consider "welcoming to newbies", or whatever it
> > is kernel subsystem maintainers have to be nowadays *g*...
>
> So, my general policy on this is that I tend to push back on patches
> which don't just work with the toolset (subject lines are just one part
> of it) to a variable extent depending on who's submitting and what
> they're submitting. One of the factors is that the more patches are
> coming from someone the easier I expect their patches to be to work
> with.
>
> The reason this came up is that this is one of the issues with Joe's
> patches (which are rather frequent) but he is only willing to do things
> that he can automate.

Hehe, I know that I wouldn't want to hand edit every autogenerated patch
people throw at me... What about just dropping everything before the
last "]" or ":" and putting an autogenerated prefix before it in a
pre-commit hook on your side?

That should work most of the time... don't know... maybe other
subsystem maintainers have some more suggestions on reducing the
workload... this could even be an interesting topic for some summit...

Regards,
Flo



\
 
 \ /
  Last update: 2010-11-16 20:39    [from the cache]
©2003-2011 Jasper Spaans