lkml.org 
[lkml]   [2010]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1.3 4/4] keys: add new key-type encrypted
From
Date
On Tue, 2010-11-16 at 14:08 +0000, David Howells wrote: 
> Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
>
> > Am assuming you mean something like this:
> >
> > keyctl add encrypted name "new trusted:master-key-name keylen" ring
> > keyctl add encrypted name "new user:master-key-name keylen" ring
> >
> > and, as you said, works without changing the API.
>
> No, that's not what I mean. I maeant that when your internal functions look
> for the user key, they should preface the description with a prefix.
>
> It should be handled in request_user_key() or request_master_key(). The
> description given to request_trusted_key() should have the prefix applied
> there. There's no need to mention it at all in the encrypted key add_key
> command line.
>
> David

I actually like keyctl requiring 'trusted:' or 'user:'. Forcing the
user to indicate which type of key they want, is actually good - no
misunderstandings. Another benefit, would be allowing 'keyctl update' to
update the key description, not the key type.

Mimi



\
 
 \ /
  Last update: 2010-11-16 15:41    [W:0.104 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site