[lkml]   [2010]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
    On Mon, 2010-11-15 at 19:34 +0000, Mark Brown wrote:
    > On Mon, Nov 15, 2010 at 11:14:18AM -0800, Joe Perches wrote:
    > > On Mon, 2010-11-15 at 19:07 +0000, Mark Brown wrote:
    > > > I'd suggest using pattern matching to look up the
    > > > rules for generating the prefixes (it's pretty much entirely prefixes)
    > > > in the same way you're handling figuring out who to mail - that'd
    > > > probably cover it in an automatable fashion.
    > > Publish a tool that works and I'll use it.
    > It appears your scripts are already hooked into which
    > would seem the obvious place to do this? Sadly I don't do perl, though
    > it looks like you're doing pretty much all the work on that anyway.

    Sadly, no it's not the right place.

    That script just generates cc email addresses
    for pre-formatted commit patches.

    It'd have to be a script that modifies the git commit subject line
    to the taste of the subsystem maintainer.

    Right now, I use a commit script that's something like:

    echo "$1: Remove unnecessary semicolons" > msg
    echo >> msg
    #cat >> msg <<EOF
    #Unnecessary semicolons should not exist.
    git commit -s -F msg $1

    There could be a modification to $1 (path)
    or some such.

    Maybe a script like
    or something.

    Care to write one in sh/bash/perl/python/c/ocaml/c#?

    As far as I know, the only subsystem pedants^H^H^H^H^Hople
    that care much about the commit subject style are
    arch/x86 and sound.

    I can understand the desire of these subsystem maintainers
    to have a consistent style. I think though that requiring
    a subject header style without providing more than a
    general guideline is a but much.

    I'd use any other automated tool you want to provide.

    cheers, Joe

     \ /
      Last update: 2010-11-15 20:55    [W:0.020 / U:52.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site