lkml.org 
[lkml]   [2010]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] EG20T: Update PCH_UART driver to 2.6.36
On Mon, Nov 15, 2010 at 09:26:03PM +0900, Tomoya MORINAGA wrote:
> + spin_lock_irqsave(&port->lock, flags);
> +
> + uart_update_timeout(port, termios->c_cflag, baud);
> + rtn = pch_uart_hal_set_line(priv, baud, parity, bits, stb);
> + if (rtn)

You need a spin_unlock_irqrestore(&port->lock, flags); here.

> + return;
> +
> + /* Don't rewrite B0 */
> + if (tty_termios_baud_rate(termios))
> + tty_termios_encode_baud_rate(termios, baud, baud);
> +
> + spin_unlock_irqrestore(&port->lock, flags);
> +}

regards,
dan carpenter


\
 
 \ /
  Last update: 2010-11-15 13:43    [from the cache]
©2003-2011 Jasper Spaans