lkml.org 
[lkml]   [2010]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] Add generic exponentially weighted moving average (EWMA) function
KOSAKI Motohiro wrote:
>>> Why do ewma_init() and ewma_add() return their first argument? They look
>>> to me like they can be straight-forward void functions.
>> You are right, for ewma_init() it does not make sense.
>>
>> For ewma_add() I think it does. This has been discussed before (e.g.
>> http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-10/msg09124.html).
>> Some people might want to get the value when they add a sample by using
>> ewma_get(ewma_add(&ewma, val));
>
> ewma_add(&ewma, val);
> ewma_get(&ewma);
>
> is enough simpler and cleaner. I don't oppse this :)

There are more candidate colors for the bike shed: :-)
- an ewma_add_return could do what ewma_get(ewma_add(...)) is meant for,
- or ewma_add itself could return the result.

BTW, isn't "get" more usually used as a prefix for these kinds of functions in
kernel APIs? "get" as a suffix more often means "get a reference" alias
increase reference count rather than "get the value".
--
Stefan Richter
-=====-==-=- =-== -===-
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2010-11-14 09:59    [W:0.819 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site