lkml.org 
[lkml]   [2010]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v2)
On 11/14/2010 01:50 AM, Ingo Molnar wrote:
>
> It's being frowned upon btw, because it's easy to overlook (and for other reasons) -
> please dont use statics inside functions - please put them in front of the function
> or further up into file scope.
>

What? What is wrong with static variables in functions? It really
doesn't seem to be a good idea to make them file-scope if they don't
need to be.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2010-11-15 05:25    [from the cache]
©2003-2011 Jasper Spaans