lkml.org 
[lkml]   [2010]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/3] mm,vmscan: Reclaim order-0 and compact instead of lumpy reclaim when under light pressure
    Date
    > On Thu, Nov 11, 2010 at 07:07:04PM +0000, Mel Gorman wrote:
    > > + if (COMPACTION_BUILD)
    > > + sc->lumpy_reclaim_mode = LUMPY_MODE_COMPACTION;
    > > + else
    > > + sc->lumpy_reclaim_mode = LUMPY_MODE_CONTIGRECLAIM;
    > >
    >
    > Gack, I posted the slightly wrong version. This version prevents lumpy
    > reclaim ever being used. The figures I posted were for a patch where
    > this condition looked like
    >
    > if (COMPACTION_BUILD && priority > DEF_PRIORITY - 2)
    > sc->lumpy_reclaim_mode = LUMPY_MODE_COMPACTION;
    > else
    > sc->lumpy_reclaim_mode = LUMPY_MODE_CONTIGRECLAIM;

    In all other place, heavy reclaim detection are used folliowing.

    if (priority < DEF_PRIORITY - 2)


    So, "priority >= DEF_PRIORITY - 2" is more symmetric, I think. but if you have strong
    reason, I don't oppse.





    \
     
     \ /
      Last update: 2010-11-14 06:45    [W:0.022 / U:29.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site