Messages in this thread | | | Subject | Re: [PATCH 1/5] mtd: fix bdev exclusive open bugs in block2mtd::add_device() | From | Artem Bityutskiy <> | Date | Sat, 13 Nov 2010 12:38:55 +0200 |
| |
Hi,
On Mon, 2010-11-01 at 17:15 +0100, Tejun Heo wrote: > + if (!IS_ERR(bdev)) { > + int ret; > + ret = bd_claim(bdev, dev); > + if (ret) { > + blkdev_put(bdev, > + FMODE_READ | FMODE_WRITE);
Would be a bit cleaner to define ea temporary variable:
fmode_t mode = FMODE_READ | FMODE_WRITE;
Would you to re-send with this little change please?
And ideally, 2 independent patches would be nicer because you fix 2 independent issues.
-- Best Regards, Artem Bityutskiy (Артём Битюцкий)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |