Messages in this thread | | | Subject | Re: [PATCH 1/2] perf-events: Add support for supplementary event registers v2 | From | Peter Zijlstra <> | Date | Sat, 13 Nov 2010 11:32:47 +0100 |
| |
On Sat, 2010-11-13 at 11:13 +0100, Andi Kleen wrote: > > Hrmm,. this doesn't really scale right wrt multiple extra_regs. > > > > You made the extra_regs thing fairly extensible, but the above doesn't > > really work well if there's multiple extra regs (say OFFCORE and > > LBR_CONFIG -- possibly even the two OFFCORE regs present on westmere). > > > > It basically needs a per-core state for each extra_reg possible. > > It shouldn't be too hard to extend it to use a table. I didn't want > to do that for the first iteration. I guess it could be done as followons > once LBR is implemented.
Isn't it also relevant for the two offcore regs for wsm?
| |