Messages in this thread | | | Subject | Re: [PATCH 2/3] perf: Add support for extra parameters for raw events | From | Peter Zijlstra <> | Date | Fri, 12 Nov 2010 11:48:47 +0100 |
| |
On Fri, 2010-11-12 at 11:41 +0100, Stephane Eranian wrote: > > Can't remember if the load-latency msr is per-core, but its an extra reg > > that needs to be set. > > Load latency is luckily per thread. Nothing special to do to handle this one. > We can restore its value from attr->config.
Right, but in effect Andi adds two pieces of infrastructure,
- extra_reg, which determines if a particular cntr value needs extra data, this is useful for both the offcore msr and the pebs-ll msr.
- per-core constraints, which is useful for shared msrs like the offcore and lbr config things.
So while his current patch set only uses either piece once -- to provide offcore support -- both pieces have in fact at least one more potential user (for future patches).
| |