lkml.org 
[lkml]   [2010]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ASoC: Add MAX98089 CODEC driver

    Thanks for pointing out the I2C device ID. After looking at the existing
    drivers that have multiple I2C IDs, I see that the devices can be uniquely
    identified. With this we should be able to accommodate both devices with
    the same driver.


    On 11/11/2010 03:18 PM, Mark Brown wrote:
    > On Thu, Nov 11, 2010 at 02:21:07PM -0600, Jesse Marroquin wrote:
    >> This patch adds the initial driver for the MAX98089 CODEC.
    >
    > I've not read this properly yet but on a first quick scan through this
    > bears a more than passing resemblance to the MAX98088 driver - are there
    > sufficient incompatibilities between the chips to warrant having a
    > separate driver? http://datasheets.maxim-ic.com/en/ds/MAX98088.pdf
    > would suggest not...
    >
    > Keeping a single driver means less code to maintain, which is generally
    > a win. Variations between the parts can be accommodated by registering
    > different controls and so on based on the I2C device ID that the system
    > registers.
    >



    \
     
     \ /
      Last update: 2010-11-12 00:19    [W:2.713 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site