lkml.org 
[lkml]   [2010]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1.3 2/4] key: add tpm_send command
Date
From
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

> Reviewd-by: Mimi Zohar <zohar@watson.ibm.com>

You've missed an 'e'.

> +int tpm_send(u32 chip_num, char *cmd, int buflen)
> +{
> ...
> + rc = transmit_cmd(chip, (struct tpm_cmd_t *)cmd, buflen,
> + "attempting tpm_cmd");

Make cmd 'void *' to obviate the cast. Preferably it should be const too.

> + module_put(chip->dev->driver->owner);

Where's the corresponding module_get()? I suspect this should be wrapped to
match tpm_chip_find_get().

David


\
 
 \ /
  Last update: 2010-11-11 20:51    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site