[lkml]   [2010]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/3] perf: Add support for extra parameters for raw events
    On 11/11/2010 10:39 AM, Andi Kleen wrote:
    >> It's not clear to me that a comma is the best character to use in this
    >> instance, because multiple events can be listed after the -e separated
    >> by commas as well, for example: -e rXXXX,cycles.
    >> -e rXXXX,YYYY,cycles would be confusing to read.
    >> How about -e rXXXX[+YYYY]
    > That's a good point. The comma seems to work in my testing though for
    > some reason, but I guess
    > I broke the multiple events case then. I'll switch over to +
    > -Andi

    I think it would have parsed OK, but it is a confusing syntax to look
    at. I should point out that there are also the u,k,h modifiers which
    can be specified, even on raw events, so the full syntax looks something

    -e rXXXX[+YYYY][:u|:k|:h]

    - Corey

     \ /
      Last update: 2010-11-11 20:41    [W:0.020 / U:11.144 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site