lkml.org 
[lkml]   [2010]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 7/5] block: clean up blkdev_get() wrappers and their users
    From
    Date
    Hi,

    On Thu, 2010-11-11 at 18:11 +0100, Tejun Heo wrote:
    > After recent blkdev_get() modifications, open_by_devnum() and
    > open_bdev_exclusive() are simple wrappers around blkdev_get().
    > Replace them with blkdev_get_by_dev() and blkdev_get_by_path().
    >
    > blkdev_get_by_dev() is identical to open_by_devnum().
    > blkdev_get_by_path() is slightly different in that it doesn't
    > automatically add %FMODE_EXCL to @mode.
    >
    > All users are converted. Most conversions are mechanical and don't
    > introduce any behavior difference. There are several exceptions.
    >
    > * btrfs now sets FMODE_EXCL in btrfs_device->mode, so there's no
    > reason to OR it explicitly on blkdev_put().
    >
    > * gfs2, nilfs2 and the generic mount_bdev() now set FMODE_EXCL in
    > sb->s_mode.
    >
    > * With the above changes, sb->s_mode now always should contain
    > FMODE_EXCL. WARN_ON_ONCE() added to kill_block_super() to detect
    > errors.
    >
    > The new blkdev_get_*() functions are with proper docbook comments.
    > While at it, add function description to blkdev_get() too.
    >
    > Signed-off-by: Tejun Heo <tj@kernel.org>
    > Cc: Philipp Reisner <philipp.reisner@linbit.com>
    > Cc: Neil Brown <neilb@suse.de>
    > Cc: Mike Snitzer <snitzer@redhat.com>
    > Cc: Joern Engel <joern@lazybastard.org>
    > Cc: Chris Mason <chris.mason@oracle.com>
    > Cc: Jan Kara <jack@suse.cz>
    > Cc: "Theodore Ts'o" <tytso@mit.edu>
    > Cc: KONISHI Ryusuke <konishi.ryusuke@lab.ntt.co.jp>
    > Cc: reiserfs-devel@vger.kernel.org
    > Cc: xfs-masters@oss.sgi.com
    > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
    Acked-by: Steven Whitehouse <swhiteho@redhat.com>

    Steve.




    \
     
     \ /
      Last update: 2010-11-11 20:23    [W:4.045 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site