lkml.org 
[lkml]   [2010]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/2] opticon: use generic code where possible
From
On Mon, Oct 25, 2010 at 9:48 PM, Alon Ziv <alon@nolaviz.org> wrote:
>> Here it seems you're turning write into a blocking function if you have
>> no bulk-out end-point. I'm not sure that is desired.
>
> Right...
> I considered doing it differently (which would require more code--I
> would need to track the outstanding control URBs, and would need a
> callback to free the kmalloc()ed setup packet). In the end, I left it as
> blocking because the actual protocol used by the OPN2001 is very light
> on writes (in fact, it never writes anything without waiting for a
> response, and its longest outgoing message is
> limited to 70 bytes).

But you already had a working non-blocking implementation in place
(authored by yourself, if I'm not mistaken) which did exactly that.
Why not simply keep it?

Thanks,
Johan


\
 
 \ /
  Last update: 2010-11-11 17:25    [W:0.055 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site