[lkml]   [2010]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 03/20] x86, mce: Add persistent MCE event
On Wed, Nov 10, 2010 at 05:21:57PM -0500, Ingo Molnar wrote:
> * Ben Gamari <> wrote:
> > On Thu, 4 Nov 2010 16:36:39 +0100, Borislav Petkov <> wrote:
> > > From: Borislav Petkov <>
> > >
> > > Add the necessary glue to enable the mce_record tracepoint on boot
> > > turning it into a persistent event. This exports the MCE buffer
> > > read-only to a userspace daemon which will hook into it through debugfs
> > > when booting is finished.
> >
> > While MCE technically is a diagnostics service, do we want to start adding
> > dependencies on debugfs in long-running, common-place daemons? I was under the
> > impression we were to avoid using debugfs for anything other than values for
> > one-off debugging.
> See this current discussion thread on lkml:
> [RFC][PATCH] perf: sysfs type id
> Events are being added to sysfs as we want to avoid the debugfs dependency.

Yep, event enumeration will land in /sysfs eventually but in this case
debugfs is used to export the buffers with the events recorded so far to
the daemon which mmaps them. And I remember also being mentioned that
debugfs will thus be always compiled in because of that.

In any case, we need some kind of a facility with which to export those
buffers for userspace to mmap. sysfs is clearly not that and debugfs is
what we currently use. I'm open for better suggestions though.



Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

 \ /
  Last update: 2010-11-11 07:21    [W:0.060 / U:13.604 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site