Messages in this thread |  | | | Date | Wed, 10 Nov 2010 15:28:41 -0800 | | From | Dmitry Torokhov <> | | Subject | Re: [RFC v1 PATCH 3/6] led: pmic8058: Add PMIC8058 leds driver |
| |
On Wed, Nov 10, 2010 at 09:45:05PM +0100, Lars-Peter Clausen wrote: > Trilok Soni wrote: > > + > > +static void led_kp_set(struct pmic8058_led_data *led, enum led_brightness value) > > +{ > > + int rc; > > + u8 level; > > + unsigned long flags; > > + > > + spin_lock_irqsave(&led->value_lock, flags); > This function is only ever called from within the workqueue so there is no need for > locking. >
That is a common misconception, unfortunately. The same work may be executing on several CPUs at the same time if it was scheduled on multi-threaded work queue.
...
> > + schedule_work(&led->work);
And sure enough, keventd is such workqueue.
Now, whether having the same work run simultaneously is OK or not is a different question altogether... -- Dmitry
|  |