lkml.org 
[lkml]   [2010]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/5] ecryptfs fixes
Date
Hi Tyler

thanks for accepting my patches.
There is another O_RDONLY test in the function ecryptfs_privileged_open(), in the file fs/ecryptfs/kthread.c,
that is not actually fixed, because i need some explanations on the code.
In this function the dentry_open() is called first time with flags (O_LARGEFILE | O_RDWR) or
(O_LARGEFILE | O_RDONLY) depending on the options passed during the mount of the lower
filesystem.
If the dentry_open() fails, a lower_file pointer can be obtained from the function ecryptfs_threadfn()
executed by the kernel kthread service. However, this option is available only if the lower filesystem
is mounted in read-write mode.
Can you explain me this?
Thanks.

Roberto


On Tuesday, November 09, 2010 11:01:44 pm Tyler Hicks wrote:
> On Wed Nov 03, 2010 at 11:11:06AM +0100, Roberto Sassu <roberto.sassu@polito.it> wrote:
> > This patch set applies to the latest kernel 2.6.37-rc1.
> >
> >
> > Roberto Sassu (5):
> > ecryptfs: moved ECRYPTFS_SUPER_MAGIC definition to linux/magic.h
> > ecryptfs: missing initialization of the superblock 'magic' field
> > ecryptfs: test lower_file pointer when lower_file_mutex is locked
> > ecryptfs: fixed testing of file descriptor flags
> > ecryptfs: open lower files with kthread credentials
>
> Hey Roberto - I pushed these patches to
> git://git.kernel.org/pub/scm/linux/kernel/git/ecryptfs/ecryptfs-2.6.git#next
>
> Thanks,
> Tyler
>
> >
> > fs/ecryptfs/ecryptfs_kernel.h | 4 +---
> > fs/ecryptfs/file.c | 20 +++++++++-----------
> > fs/ecryptfs/inode.c | 32 ++++++++++++++------------------
> > fs/ecryptfs/kthread.c | 17 +++++++++++++----
> > fs/ecryptfs/main.c | 5 +++--
> > include/linux/magic.h | 1 +
> > 6 files changed, 41 insertions(+), 38 deletions(-)
> >
>
>
>


\
 
 \ /
  Last update: 2010-11-10 10:37    [W:0.056 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site