Messages in this thread Patch in this message | | | From | Andy Lutomirski <> | Subject | [PATCH] Improve clocksource unstable warning | Date | Wed, 10 Nov 2010 17:16:46 -0500 |
| |
When the system goes out to lunch for a long time, the clocksource watchdog might get false positives. Clarify the warning so that people stop blaming their system freezes on the timing code.
This change was Thomas Gleixner's suggestion.
Signed-off-by: Andy Lutomirski <luto@mit.edu> --- I've only compile-tested on 2.6.36, but it applies cleanly to Linus' tree and it's rather trivial.
kernel/time/clocksource.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index c18d7ef..5b30aa2 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -215,8 +215,10 @@ static void __clocksource_unstable(struct clocksource *cs) static void clocksource_unstable(struct clocksource *cs, int64_t delta) { - printk(KERN_WARNING "Clocksource %s unstable (delta = %Ld ns)\n", - cs->name, delta); + printk(KERN_WARNING "Clocksource %s unstable (delta = %Ld ns)%s\n", + cs->name, delta, + delta < -5000000000LL ? + " or your system lagged for other reasons" : ""); __clocksource_unstable(cs); } -- 1.7.3.2
| |