lkml.org 
[lkml]   [2010]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 10 Nov 2010 22:32:44 +0100 (CET)
FromJesper Juhl <>
SubjectRe: [PATCH] SUNRPC: Simplify rpc_alloc_iostats by removing pointless local variable
On Sun, 7 Nov 2010, Jesper Juhl wrote:

> Hi,
>
> We can simplify net/sunrpc/stats.c::rpc_alloc_iostats() a bit by getting
> rid of the unneeded local variable 'new'.
>
>
> Please CC me on replies.
>
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> stats.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git
> a/net/sunrpc/stats.c b/net/sunrpc/stats.c
> index f71a731..80df89d 100644
> --- a/net/sunrpc/stats.c
> +++ b/net/sunrpc/stats.c
> @@ -115,9 +115,7 @@ EXPORT_SYMBOL_GPL(svc_seq_show);
> */
> struct rpc_iostats *rpc_alloc_iostats(struct rpc_clnt *clnt)
> {
> - struct rpc_iostats *new;
> - new = kcalloc(clnt->cl_maxproc, sizeof(struct rpc_iostats), GFP_KERNEL);
> - return new;
> + return kcalloc(clnt->cl_maxproc, sizeof(struct rpc_iostats), GFP_KERNEL);
> }
> EXPORT_SYMBOL_GPL(rpc_alloc_iostats);
>
>
>

Ok, no response to this for a couple of days.
Is there some problem or did it just get missed?
Could someone merge this and push it up-stream, please, if there are no
problems with it...


--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2010-11-10 22:47    [from the cache]
©2003-2010