lkml.org 
[lkml]   [2010]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iSeries: Don't leak if allocations fail in mf_getSrcHistory
Hi Jesper,

On Mon, 01 Nov 2010 22:10:42 +1100 Michael Ellerman <michael@ellerman.id.au> wrote:
>
> On Sat, 2010-10-30 at 19:20 +0200, Jesper Juhl wrote:
> >
> > If memory is tight and a dynamic allocation fails there's no reason to
> > make a bad situation worse by leaking memory.
> >
> > mf_getSrcHistory potentially leaks pages[0-3]. I believe the right thing
> > to do is to free that memory again before returning -ENOMEM - which is
> > what this patch does.
> >
> > I realize that the function is under '#if 0' so this probably doesn't
> > matter much, but I assume that the function is still there for a reason
> > (but I could be wrong, I don't know the powerpc code).
> > Anyway, I suggest we remove the leak.
>
> Stephen is the iSeries maintainer, and I think he #if 0'ed the code. But
> I don't think it will ever be un-ifdef'ed, so should probably just be
> removed.

Well, only unofficially iseries maintainer :-)

Yes, just remove the whole function ... it was never used and never will
be.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-11-01 21:13    [W:0.086 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site