Messages in this thread | | | Date | Mon, 1 Nov 2010 15:19:37 -0200 | From | Marcelo Tosatti <> | Subject | Re: [patch v2] x86: kvm: x86: fix information leak to userland |
| |
On Sat, Oct 30, 2010 at 10:54:47PM +0400, Vasiliy Kulikov wrote: > Structures kvm_vcpu_events, kvm_debugregs, kvm_pit_state2 and > kvm_clock_data are copied to userland with some padding and reserved > fields unitialized. It leads to leaking of contents of kernel stack > memory. We have to initialize them to zero. > > In patch v1 Jan Kiszka suggested to fill reserved fields with zeros > instead of memset'ting the whole struct. It makes sense as these > fields are explicitly marked as padding. No more fields need zeroing. > > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> > --- > Compile tesed only. > > arch/x86/kvm/x86.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-)
Applied, thanks.
| |