lkml.org 
[lkml]   [2010]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: All Applied micro boards are failing with current mainline kernel
    From
    From: Stephen Rothwell <sfr@canb.auug.org.au>
    Date: Tue, 2 Nov 2010 02:36:50 +1100

    > Hi Josh,
    >
    > On Mon, 1 Nov 2010 11:05:53 -0400 Josh Boyer <jwboyer@gmail.com> wrote:
    >>
    >> A few hints would be appreciated.
    >
    > Remove the call to netif_stop_queue() from emac_probe(). Apparently,
    > calling this before register_netdev() is now wrong (maybe always was).

    Right.

    I'll add this to net-2.6

    --------------------
    ibm_newemac: Remove netif_stop_queue() in emac_probe().

    Touching the queue state before register_netdev is not
    allowed, and besides the queue state before ->open()
    is "don't care"

    Reported-by: Josh Boyer <jwboyer@gmail.com>
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    ---
    drivers/net/ibm_newemac/core.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
    index 385dc32..06bb9b7 100644
    --- a/drivers/net/ibm_newemac/core.c
    +++ b/drivers/net/ibm_newemac/core.c
    @@ -2871,7 +2871,6 @@ static int __devinit emac_probe(struct platform_device *ofdev,
    SET_ETHTOOL_OPS(ndev, &emac_ethtool_ops);

    netif_carrier_off(ndev);
    - netif_stop_queue(ndev);

    err = register_netdev(ndev);
    if (err) {
    --
    1.7.3.2


    \
     
     \ /
      Last update: 2010-11-01 16:53    [W:0.023 / U:32.356 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site