Messages in this thread | | | Date | Sat, 9 Oct 2010 14:20:47 -0700 | From | Greg KH <> | Subject | Re: [PATCH 8/19]: SCST SYSFS interface implementation |
| |
On Sat, Oct 02, 2010 at 01:46:21AM +0400, Vladislav Bolkhovitin wrote: > This patch contains SYSFS interface implementation.
Nice, but you forgot to document it. All sysfs changes need to be documented in Documentation/ABI/
Please add a file to this patch that does so.
> +static void scst_tgtt_release(struct kobject *kobj) > +{ > + struct scst_tgt_template *tgtt; > + > + tgtt = container_of(kobj, struct scst_tgt_template, tgtt_kobj); > + complete_all(&tgtt->tgtt_kobj_release_cmpl); > + return;
Don't you also need to free the memory of your kobject here?
> +static void scst_tgt_release(struct kobject *kobj) > +{ > + struct scst_tgt *tgt; > + > + tgt = container_of(kobj, struct scst_tgt, tgt_kobj); > + complete_all(&tgt->tgt_kobj_release_cmpl); > + return;
Same here, no kfree?
> +static void scst_acg_release(struct kobject *kobj) > +{ > + struct scst_acg *acg; > + > + acg = container_of(kobj, struct scst_acg, acg_kobj); > + complete_all(&acg->acg_kobj_release_cmpl);
And here.
thanks,
greg k-h
| |