Messages in this thread | | | Date | Fri, 8 Oct 2010 10:15:33 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 06/18] fs: Clean up inode reference counting |
| |
On Fri, Oct 08, 2010 at 06:46:43PM +1100, Dave Chinner wrote: > > Also any chance to get an assert under a debug option the the reference > > count really is non-zero? > > For iref()? Sure, but I think WARN_ON_ONCE() is better for the moment, > though.
I don't think a WARN_ON_ONCE is too helpful - there could be all kinds of different filesystems having that issue. Also I think a plain WARN_ON is cheaper than a WARN_ON_ONCE and this is a rather hot codepath.
| |