lkml.org 
[lkml]   [2010]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: avoid deadlock when disabling regulator with supply
On Fri, Oct 08, 2010 at 01:43:54PM -0500, Jeffrey Carlyle wrote:

> I have a regulator A that sets regulator B as its supply. When I call
> set_supply to add B as the supply for A, regulator A gets added to the
> supply_list for regulator B.

Looks good, thanks!

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

but some stylistic things below:

> Change-Id: I769669452b9e1b59b252298d589738aabb03529c

Hrm?

> static int _regulator_get_voltage(struct regulator_dev *rdev);
> static int _regulator_get_current_limit(struct regulator_dev *rdev);
> static unsigned int _regulator_get_mode(struct regulator_dev *rdev);
> @@ -1343,12 +1344,14 @@ int regulator_enable(struct regulator *regulator)
> mutex_lock(&rdev->mutex);
> ret = _regulator_enable(rdev);
> mutex_unlock(&rdev->mutex);
> +
> return ret;
> }
> EXPORT_SYMBOL_GPL(regulator_enable);

Random indentation change here.

> +
> + if (supply_rdev)
> + regulator_disable(
> + get_device_regulator(rdev_get_dev(supply_rdev))
> + );
> +

Eew, indentation! In cases like this it's better to just ignore the
excesive line length.


\
 
 \ /
  Last update: 2010-10-08 20:59    [W:0.438 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site