[lkml]   [2010]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 05/18] fs: inode split IO and LRU lists
    > -	struct list_head	i_list;		/* backing dev IO list */
    > + struct list_head i_io; /* backing dev IO list */
    > + struct list_head i_lru; /* backing dev IO list */

    a) that pair of comments would be disqualified in IOCCC ;-)
    b) have a pity on folks who will have to talk about the code. I mean,
    how would you say that? Ai-Ai-Oh?

    > +extern struct percpu_counter nr_inodes;
    > +extern struct percpu_counter nr_inodes_unused;

    Ehh... At least take that to fs/internal.h. Preferably don't expose at

    > - list_del(&inode->i_list);
    > - list_add(&inode->i_list, &bdi->wb.b_dirty);
    > + list_del(&inode->i_io);
    > + list_add(&inode->i_io, &bdi->wb.b_dirty);

    list_move()? Ditto for the next few. And, while that's not directed
    at you, this kind of loops is Not Nice(tm)...

     \ /
      Last update: 2010-10-08 11:19    [W:2.146 / U:0.056 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site