lkml.org 
[lkml]   [2010]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 6 Oct 2010 15:51:04 -0700
FromGreg KH <>
SubjectRe: [PATCH] staging: fix possible use-before-NULL-check crash
On Wed, Oct 06, 2010 at 03:39:41PM -0700, Kees Cook wrote:
> Found via http://coccinelle.lip6.fr/rules/mini_null_ref.cocci
>
> Signed-off-by: Kees Cook <kees.cook@canonical.com>
> ---
> drivers/staging/tm6000/tm6000-alsa.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/tm6000/tm6000-alsa.c b/drivers/staging/tm6000/tm6000-alsa.c
> index 087137d..c1aff0e 100644
> --- a/drivers/staging/tm6000/tm6000-alsa.c
> +++ b/drivers/staging/tm6000/tm6000-alsa.c
> @@ -426,10 +426,11 @@ error:
>
> static int tm6000_audio_fini(struct tm6000_core *dev)
> {
> - struct snd_tm6000_card *chip = dev->adev;
> + struct snd_tm6000_card *chip;
>
> if (!dev)
> return 0;
> + chip = dev->adev;

Nice catch, but I don't think that the dev pointer can ever be NULL
here.

Mauro, can you queue this up through your tree, as you handle this one?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-10-07 00:53    [from the cache]
©2003-2010