lkml.org 
[lkml]   [2010]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate init/exit
    On Wed, Oct 6, 2010 at 12:44 PM, Robert Richter <robert.richter@amd.com> wrote:
    > On 06.10.10 14:23:17, Grant Likely wrote:
    >> >> diff --git a/drivers/oprofile/oprof.c b/drivers/oprofile/oprof.c
    >> >> index b336cd9..76d97a5 100644
    >> >> --- a/drivers/oprofile/oprof.c
    >> >> +++ b/drivers/oprofile/oprof.c
    >> >> @@ -252,6 +252,8 @@ static int __init oprofile_init(void)
    >> >>  {
    >> >>       int err;
    >> >>
    >> >> +     memset(&oprofile_ops, 0, sizeof(struct oprofile_operations));
    >> >> +
    >> >
    >> > Yes, this looks much better. Thanks Paul.
    >>
    >> oprofile_ops is allocated in bss and so is already zeroed.  No need to
    >> do it explicitly.
    >
    > Before oprofile_arch_init() it isn't necessarily needed, but we should
    > definitely add it before oprofile_timer_init(). For code readability I
    > would rather tend to let the first in too.

    ? Sorry, I don't understand what you're trying to say. Because
    oprofile_ops is statically allocated in bss; it will be zeroed before
    *any* of the init hooks is called.

    g.

    >
    > -Robert
    >
    > --
    > Advanced Micro Devices, Inc.
    > Operating System Research Center
    >
    >



    --
    Grant Likely, B.Sc., P.Eng.
    Secret Lab Technologies Ltd.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-10-06 21:01    [W:0.023 / U:90.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site