lkml.org 
[lkml]   [2010]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH wireless-2.6 or stable] iwlwifi: return error when fail to start scanning
    From
    Date
    On Wed, 2010-10-06 at 10:45 -0700, Florian Mickler wrote:
    > Hi Stanislaw!
    >
    > On Wed, 6 Oct 2010 18:04:35 +0200
    > Stanislaw Gruszka <sgruszka@redhat.com> wrote:
    >
    > > This is stable friendly backport of wireless-testing commit
    > > 3eecce527c7434dfd16517ce08b49632c8a26717 "iwlwifi: unify scan start
    > > checks". Wireless-testing version include also a lot of cleanups.
    > >
    > > On error case in {iwl3945,iwlagn}_request_scan we queue abort_scan work,
    > > which in a fact do nothing, so we never complete the scan. Thats gives
    > > "WARNING: at net/wireless/core.c:614 wdev_cleanup_work" and stopped
    > > network connection until reload iwlwifi modules. Return of -EIO and
    > > stopping queuing any work is a fix.
    > >
    > > Note there are still many cases when we can get:
    > >
    > > WARNING: at net/wireless/core.c:614 wdev_cleanup_work
    > > WARNING: at net/mac80211/scan.c:266 ieee80211_scan_completed
    > > WARNING: at net/mac80211/scan.c:269 ieee80211_scan_complete
    > >
    > > which are not fixed. Unfortunately does not exist single, small fix
    > > for that problems, and we probably will see some more bug reports
    > > with scan warnings. As solution we rewrite iwl-scan.c code to avoid
    > > all possible race conditions. That quite big patch set is queued
    > > for 2.6.37 .
    > >
    > > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
    Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>

    looks good to me

    Thanks
    Wey




    \
     
     \ /
      Last update: 2010-10-06 19:51    [W:0.023 / U:0.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site