[lkml]   [2010]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch] eicon: make buffer larger
    On Wed, 6 Oct 2010, Dan Carpenter wrote:
    > On Wed, Oct 06, 2010 at 10:44:47AM +0200, Armin Schindler wrote:
    >>> 927 strcpy (clients[id].drvName, tmp);
    >>> 928 strcpy (clients[id].Dbg.drvName, tmp);
    >>> ^
    >>> this buffer is only 16 chars
    >> Now I understand. You are right. So the fix would be to change these
    >> strcpy() to e.g. strncpy() or similar.
    > We need more than 16 characters to store the information. What is the
    > problem with just making the buffer larger?

    The larger buffer is not really needed. Later versions of the driver will
    use the strcpy/memcpy with checked size anyway.
    I just want to avoid a change in the debug structure which is used in more than one module/tool.

    But it shouldn't be a real problem.


     \ /
      Last update: 2010-10-06 14:53    [W:0.019 / U:12.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site