Messages in this thread | | | Subject | Re: [PATCH] rcu_read_lock/unlock protect find_task_by_vpid call | From | Tetsuo Handa <> | Date | Sun, 31 Oct 2010 08:33:35 +0900 |
| |
Paul E. McKenney wrote: > So we should remove the lockdep_tasklist_lock_is_held() and then > apply Sergey's patch, correct?
Yes. rcu_lockdep_assert(rcu_read_lock_held()) in find_task_by_pid_ns() is correct and callers need to use rcu_read_lock().
As of 2.6.32, there are 20+ users who missed rcu_read_lock(). So, similar reports will be posted like popcorn. http://kerneltrap.org/mailarchive/linux-kernel/2009/12/11/4518016
| |