Messages in this thread |  | | | Date | Sat, 30 Oct 2010 17:25:00 -0400 | | From | "J. Bruce Fields" <> | | Subject | Re: nfsd changes for 2.6.37 |
| |
I noticed a couple problems with the lease patches. Also:
On Wed, Oct 27, 2010 at 10:59:29AM -0400, Christoph Hellwig wrote: > On Wed, Oct 27, 2010 at 10:55:39AM -0400, J. Bruce Fields wrote: > > Hm, two problems: > > - We introduce the possibility of fcntl(fd, F_SETLEASE, F_UNLCK) > > failing with ENOMEM. > > splitt ->setlease into ->add_least and ->delete_lease. No need to pass > in a structure for the later. No need to return one either.
We still need to do this part. I just did the minimum required to fix the problem--I figure splitting out a separate ->delete_lease method (which I agree would be cleaner) could wait till the next merge window.
Patches follow, tested on top of the merge of Arnd's patches; if they look OK they can go in, or I can commit them on top of a few pending nfsd fixes and send another pull request.
It'd be nice if we get this fixed by -rc1, but not the end of the world if we don't.
--b.
|  |