lkml.org 
[lkml]   [2010]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile cflag lines
From
On 10/3/10, walter harms <wharms@bfs.de> wrote:
>
>
> Tracey Dent schrieb:
>> Changed to use the proper ccflags-y option
>>
>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>> ---
>> drivers/staging/rtl8192su/Makefile | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192su/Makefile
>> b/drivers/staging/rtl8192su/Makefile
>> index 7133894..1120c04 100644
>> --- a/drivers/staging/rtl8192su/Makefile
>> +++ b/drivers/staging/rtl8192su/Makefile
>> @@ -1,12 +1,12 @@
>> NIC_SELECT = RTL8192SU
>>
>> -EXTRA_CFLAGS += -std=gnu89
>> -EXTRA_CFLAGS += -O2
>> +ccflags-y := -std=gnu89
>> +ccflags-y += -O2
>>
>
>
> I still do not think that -O2 belongs here.
> it should simply be removed.

True it should, but all i did was change the EXTRA_CFLAGS to ccflags-y.

>
> re,
> wh
>
>
>
>> -EXTRA_CFLAGS += -DJACKSON_NEW_RX
>> -EXTRA_CFLAGS += -DTHOMAS_BEACON
>> +ccflags-y += -DJACKSON_NEW_RX
>> +ccflags-y += -DTHOMAS_BEACON
>>
>> -#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
>> +#ccflags-y += -DMUTIPLE_BULK_OUT
>>
>> r8192s_usb-objs := \
>> r8192U_wx.o \
>


TD


\
 
 \ /
  Last update: 2010-10-03 23:01    [W:0.914 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site