lkml.org 
[lkml]   [2010]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/urgent] x86-32: Restore irq stacks NUMA-aware allocations
On Fri, Oct 29, 2010 at 08:32:26PM +0200, Peter Zijlstra wrote:
> On Fri, 2010-10-29 at 06:43 +0000, tip-bot for Eric Dumazet wrote:
> > + irqctx = page_address(alloc_pages_node(cpu_to_node(cpu),
> > + THREAD_FLAGS,
> > + THREAD_ORDER));
>
> Shouldn't we be checking for a NULL return from alloc_pages_node()
> before calling page_address() on it?

It seems at this stage it's a panic() or BUG_ON candidate. (Which
reminds me GFP_PANIC flag proposal back in 2009 ;)

Cyrill


\
 
 \ /
  Last update: 2010-10-29 22:11    [W:0.107 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site