lkml.org 
[lkml]   [2010]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: tproxy: added IPv6 support to the socket match
Am 28.10.2010 22:00, schrieb David Miller:
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Date: Thu, 28 Oct 2010 20:51:43 +0200
>
>>> + u8 tproto;
>>
>> tproto is unsigned...
>>
>>> + const struct xt_socket_mtinfo1 *info = (struct xt_socket_mtinfo1 *) par->matchinfo;
>>> +
>>> + tproto = ipv6_find_hdr(skb, &thoff, -1, NULL);
>>
>> but ipv6_find_hdr() returns int, and negative values for errors...
>
> Thanks Geert, I'll fix it like so:
>
> --------------------
> netfilter: xt_socket: Make tproto signed in socket_mt6_v1().
>
> Otherwise error indications from ipv6_find_hdr() won't be noticed.
>
> This required making the protocol argument to extract_icmp6_fields()
> signed too.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>

Thanks for taking care of this Dave.


\
 
 \ /
  Last update: 2010-10-29 20:13    [W:0.117 / U:2.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site