lkml.org 
[lkml]   [2010]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] u64_stats_sync.h: move "inline" before the return type
    From
    Date
    With the option -Wextra, gcc emits warnings like this one:

    include/linux/u64_stats_sync.h:70: warning: 'inline' is not at beginning of declaration

    While this is legal according to the C standard, it would be more
    readable to have all modifiers before the return type.
    ---
    include/linux/u64_stats_sync.h | 12 ++++++------
    1 files changed, 6 insertions(+), 6 deletions(-)

    diff --git a/include/linux/u64_stats_sync.h b/include/linux/u64_stats_sync.h
    index fa261a0..8da8c4e 100644
    --- a/include/linux/u64_stats_sync.h
    +++ b/include/linux/u64_stats_sync.h
    @@ -67,21 +67,21 @@ struct u64_stats_sync {
    #endif
    };

    -static void inline u64_stats_update_begin(struct u64_stats_sync *syncp)
    +static inline void u64_stats_update_begin(struct u64_stats_sync *syncp)
    {
    #if BITS_PER_LONG==32 && defined(CONFIG_SMP)
    write_seqcount_begin(&syncp->seq);
    #endif
    }

    -static void inline u64_stats_update_end(struct u64_stats_sync *syncp)
    +static inline void u64_stats_update_end(struct u64_stats_sync *syncp)
    {
    #if BITS_PER_LONG==32 && defined(CONFIG_SMP)
    write_seqcount_end(&syncp->seq);
    #endif
    }

    -static unsigned int inline u64_stats_fetch_begin(const struct u64_stats_sync *syncp)
    +static inline unsigned int u64_stats_fetch_begin(const struct u64_stats_sync *syncp)
    {
    #if BITS_PER_LONG==32 && defined(CONFIG_SMP)
    return read_seqcount_begin(&syncp->seq);
    @@ -93,7 +93,7 @@ static unsigned int inline u64_stats_fetch_begin(const struct u64_stats_sync *sy
    #endif
    }

    -static bool inline u64_stats_fetch_retry(const struct u64_stats_sync *syncp,
    +static inline bool u64_stats_fetch_retry(const struct u64_stats_sync *syncp,
    unsigned int start)
    {
    #if BITS_PER_LONG==32 && defined(CONFIG_SMP)
    @@ -112,7 +112,7 @@ static bool inline u64_stats_fetch_retry(const struct u64_stats_sync *syncp,
    * - UP 32bit must disable BH.
    * - 64bit have no problem atomically reading u64 values, irq safe.
    */
    -static unsigned int inline u64_stats_fetch_begin_bh(const struct u64_stats_sync *syncp)
    +static inline unsigned int u64_stats_fetch_begin_bh(const struct u64_stats_sync *syncp)
    {
    #if BITS_PER_LONG==32 && defined(CONFIG_SMP)
    return read_seqcount_begin(&syncp->seq);
    @@ -124,7 +124,7 @@ static unsigned int inline u64_stats_fetch_begin_bh(const struct u64_stats_sync
    #endif
    }

    -static bool inline u64_stats_fetch_retry_bh(const struct u64_stats_sync *syncp,
    +static inline bool u64_stats_fetch_retry_bh(const struct u64_stats_sync *syncp,
    unsigned int start)
    {
    #if BITS_PER_LONG==32 && defined(CONFIG_SMP)


    \
     
     \ /
      Last update: 2010-10-29 19:47    [W:0.026 / U:32.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site