lkml.org 
[lkml]   [2010]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] jump label: disable due to compiler bug
From
Date
On Fri, 2010-10-29 at 09:35 -0400, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@goodmis.org) wrote:

> > Then in the code have:
> >
> > -#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL)
> > +#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL) \
>
> Technically, you could remove the dependency on
> "defined(CONFIG_HAVE_ARCH_JUMP_LABEL)", because it is now dealt with at
> the Kconfig level (CONFIG_JUMP_LABEL depends on it).

Yeah, I noticed that just after hitting send.

>
> > + && defined(JUMP_LABEL)
>
> this would be defined(CONFIG_JUMP_LABEL)

Yep, this too, but thanks for pointing it out.


>
> The rest looks fine,

Great, can I add your acked-by then?

-- Steve




\
 
 \ /
  Last update: 2010-10-29 19:37    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site