lkml.org 
[lkml]   [2010]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v4 11/11] memcg: check memcg dirty limits in page writeback
    Date
    KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes:

    > On Fri, 29 Oct 2010 00:09:14 -0700
    > Greg Thelen <gthelen@google.com> wrote:
    >
    >> If the current process is in a non-root memcg, then
    >> balance_dirty_pages() will consider the memcg dirty limits
    >> as well as the system-wide limits. This allows different
    >> cgroups to have distinct dirty limits which trigger direct
    >> and background writeback at different levels.
    >>
    >> Signed-off-by: Andrea Righi <arighi@develer.com>
    >> Signed-off-by: Greg Thelen <gthelen@google.com>
    >
    > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    >
    > Ideally, I think some comments in the code for "why we need double-check system's
    > dirty limit and memcg's dirty limit" will be appreciated.

    I will add to the balance_dirty_pages() comment. It will read:
    /*
    * balance_dirty_pages() must be called by processes which are generating dirty
    * data. It looks at the number of dirty pages in the machine and will force
    * the caller to perform writeback if the system is over `vm_dirty_ratio'.
    * If we're over `background_thresh' then the writeback threads are woken to
    * perform some writeout. The current task may have per-memcg dirty
    * limits, which are also checked.
    */


    \
     
     \ /
      Last update: 2010-10-29 19:29    [W:0.021 / U:1.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site